Add test for isValidResolvConf
#10302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco <francisco.moral@suse.com>
Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
force-pushed
the
resolvconf.test.issue.9874
branch
from
3dd624f
to
6fe7406
Compare
brandond
approved these changes
Jun 6, 2024
rancher-max
approved these changes
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10302 +/- ##
==========================================
- Coverage 47.78% 41.74% -6.05%
==========================================
Files 177 177
Lines 14801 14801
==========================================
- Hits 7073 6178 -895
- Misses 6383 7446 +1063
+ Partials 1345 1177 -168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jun 6, 2024
fmoral2
added a commit
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Francisco <francisco.moral@suse.com> (cherry picked from commit 043b1ea) Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Francisco <francisco.moral@suse.com> (cherry picked from commit 043b1ea) Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Francisco <francisco.moral@suse.com> (cherry picked from commit 043b1ea) Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
to fmoral2/k3s
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Francisco <francisco.moral@suse.com> (cherry picked from commit 043b1ea) Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
to fmoral2/k3s
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Francisco <francisco.moral@suse.com> (cherry picked from commit 043b1ea) Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
to fmoral2/k3s
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Francisco <francisco.moral@suse.com> (cherry picked from commit 043b1ea) Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Francisco <francisco.moral@suse.com>
fmoral2
added a commit
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Francisco <francisco.moral@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments